Use the read buffer for the handshake process, make the write buffer available for cert verification #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bugadani
force-pushed
the
single_buffer
branch
2 times, most recently
from
0c8fba3 to
7a0c3f6
Compare
This comment was marked as outdated.
This comment was marked as outdated.
lulf
reviewed
Apr 24, 2023
|
So far only one thing suggests this may not be a good idea: clients can send early data at basically any point of the handshake process after server hello. Since we don't support early data yet, and treat the whole handshake process as one atomic step, I think this PR is at least not completely broken. My best idea is to leave this PR hanging for a while, until we know more. It isn't very complicated and doesn't cost anything, I think :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may or may not be safe to do. It depends whether there are any read records that need to live past a response. The server cert is one such piece of data, but we pass that to the verifier, which can choose to store it however it wants to.