Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] Type Safe Navigation 적용 #300

Closed
l2hyunwoo opened this issue May 27, 2024 · 3 comments · Fixed by #301
Closed

[Improvement] Type Safe Navigation 적용 #300

l2hyunwoo opened this issue May 27, 2024 · 3 comments · Fixed by #301
Assignees
@l2hyunwoo
Labels
2024

Comments

@l2hyunwoo
Copy link
Contributor

Kind (Required)

  • Improvement

Overview (Required)

  • 기존 route(String) 기반의 네비게이션 방식에서 Type Safe 네비게이션으로의 전환을 건의드립니다. (androidx-navigation 2.8.x 대)

Links

-Navigation Compose meet Type Safety
@l2hyunwoo
Copy link
Contributor Author

✋🏻

@taehwandev
Copy link
Member

@l2hyunwoo Labels 2024 붙여주세요.

@l2hyunwoo
Copy link
Contributor Author

@taehwandev 알겠습니다!

l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 27, 2024
@l2hyunwoo
[feature/droidknights#300] Apply navigation 2.8.0-beta01
365573e
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 27, 2024
@l2hyunwoo
[feature/droidknights#300] Apply kotlinx.serialization on core:naviga…
da64edc 
…tor module
@l2hyunwoo l2hyunwoo mentioned this issue May 27, 2024
Merged
@taehwandev taehwandev assigned taehwandev and l2hyunwoo and unassigned taehwandev May 27, 2024
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Add Navigation Type
243452c
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply type on navigation route
1271849
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Update navigation to 2.8.0-beta02
32d8d8c
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply RouteModel on MainNavigator
b0a6d73
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Remove leagcy route object in navigation f…
b7919cd 
…iles
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply navigation 2.8.0-beta01
bee15e2
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply kotlinx.serialization on core:naviga…
2e4efb5 
…tor module
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Add Navigation Type
db1077f
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply type on navigation route
ee56c0f
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Update navigation to 2.8.0-beta02
78c6823
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply RouteModel on MainNavigator
1dbdb5a
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Remove leagcy route object in navigation f…
95561ac 
…iles
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply navigation 2.8.0-beta01
95156d2
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply kotlinx.serialization on core:naviga…
246b3ab 
…tor module
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Add Navigation Type
6e2c53d
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply type on navigation route
addac41
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Update navigation to 2.8.0-beta02
fcc1c3d
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply RouteModel on MainNavigator
c01e472
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Remove leagcy route object in navigation f…
8dce647 
…iles
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply code review
e45edb0
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] Apply code review
b202fb1 
[feature/droidknights#300] Apply code review
l2hyunwoo added a commit to l2hyunwoo/DroidKnightsApp that referenced this issue May 30, 2024
@l2hyunwoo
[feature/droidknights#300] detekt apply
ee817b8
wisemuji added a commit that referenced this issue May 31, 2024
@wisemuji
Merge pull request #301 from l2hyunwoo/feature/#300
c081d4e 
[feature/#300] Apply Type Safe Navigation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@l2hyunwoo l2hyunwoo

Labels
2024
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[feature/#300] Apply Type Safe Navigation l2hyunwoo/DroidKnightsApp
2 participants
@taehwandev @l2hyunwoo