Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bookmark] 북마크 모듈 및 탭 추가 #170

Merged
merged 3 commits into from
Aug 8, 2023
Merged

[Bookmark] 북마크 모듈 및 탭 추가 #170

merged 3 commits into from
Aug 8, 2023

Conversation

laco-dev
Copy link
Contributor

@laco-dev laco-dev commented Aug 6, 2023

Issue

Overview (Required)

  • 북마크 기능에 대한 사전 작업으로, 모듈 및 네비게이션 추가

Screenshot

@laco-dev laco-dev requested a review from wisemuji August 6, 2023 04:27
@laco-dev laco-dev self-assigned this Aug 6, 2023
Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

하나만 확인 부탁드립니다

BOOKMARK(
iconResId = R.drawable.ic_bookmark,
contentDescription = "북마크",
"bookmark",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BookmarkRoute를 참조하도록 변경해주세요

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

죠습니다 🦈

@laco-dev laco-dev merged commit 69cd616 into droidknights:main Aug 8, 2023
@laco-dev laco-dev deleted the feature/#168-bookmark-feature branch August 8, 2023 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bookmark] 북마크 모듈 및 탭 추가
3 participants