Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Main] 다크 모드 기능을 데이터로 관리한다 #226

Merged
merged 9 commits into from
Aug 20, 2023

Conversation

JeonK1
Copy link
Contributor

@JeonK1 JeonK1 commented Aug 18, 2023

Issue

Overview (Required)

  • DataStore (Preferences DataStore) 에 대한 의존성을 추가하였습니다.
    => Preference DataStore 가 Proto DataStore 에 비해 간편하게 추가하고 사용할 수 있어서 이를 채택하였습니다.
  • 다크모드에 대한 설정 값을 DataStore 에 저장하고 불러오는 로직 추가하였습니다.
  • DataStore 테스트코드 추가하였습니다.

Screenshot

overview

@github-actions
Copy link

github-actions bot commented Aug 18, 2023

Test Results

15 tests   15 ✔️  9s ⏱️
10 suites    0 💤
10 files      0

Results for commit bc9665f.

♻️ This comment has been updated with latest results.

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 👏
코멘트 확인 부탁드리겠습니다.

Copy link
Member

@wisemuji wisemuji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생 많으셨습니다 👏 Conflict만 확인 부탁드려요.

@wisemuji
Copy link
Member

#202 에서 의존하고 있어 이만 머지하겠습니다!

@wisemuji wisemuji merged commit 50feaf4 into droidknights:main Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Main] 다크 모드 기능을 데이터로 관리한다
3 participants