[feature/#246] bookmarkItems의 타입을 ImmutableList로 변경 #247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wisemuji
reviewed
Aug 31, 2023
| @@ -83,7 +85,7 @@ private fun BookmarkLoading() { | |||
| @Composable | |||
| private fun BookmarkScreen( | |||
| isEditMode: Boolean, | |||
| bookmarkItems: List<BookmarkItemUiState>, | |||
| bookmarkItems: ImmutableList<BookmarkItemUiState>, | |||
There was a problem hiding this comment.
PersistentList의 변경 API가 불필요하다고 생각하셔서 ImmutableList를 사용하신걸까요?
이전에 진행하셨던 이슈와 달라져서 여쭤봅니다.
There was a problem hiding this comment.
네 편집 버튼이 있어서 살짝 불안하긴 한데, 기능을 확인해보니 아이템들이 자주 위치변경된다거나 삭제되지 않을 것 같아서 ImmutableList 타입을 사용했습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)