[북마크] 일괄 삭제 기능 추가 #311
Merged
[북마크] 일괄 삭제 기능 추가 #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results19 tests 19 ✅ 5s ⏱️ Results for commit da592b8. ♻️ This comment has been updated with latest results. |
taehwandev
reviewed
Jun 3, 2024
| state.copy(selectedSessionIds = persistentSetOf()) | ||
| } | ||
| }.catch { throwable -> | ||
| _errorFlow.emit(throwable) |
There was a problem hiding this comment.
중요.
flow {} 함수에서 suspend에서 오류가 발생하면 catch로 이벤트가 오지 않습니다.
(이 코드는 의미 없는 코드에요)
flow() 이후에 오는 경우에만 여기 catch로 잡힙니다.
There was a problem hiding this comment.
리뷰 감사합니다. flow 빌더 내부에서 예외를 발생하는 경우 catch로 잡히는 것을 아래와 같이 확인했습니다.
taehwandev
requested changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview
드래그 앤 드롭으로 순서를 변경한다.→ 별도 이슈로 관리Screenshot
KakaoTalk_20240531_022422890.mp4