[Setting] 라이트 모드 / 다크 모드 설정 카드 UI #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laco-dev
changed the title
wisemuji
reviewed
Jul 21, 2023
feature/main/src/main/java/com/droidknights/app2023/feature/main/MainActivity.kt
Show resolved
Hide resolved
feature/main/src/main/java/com/droidknights/app2023/feature/main/MainNavigator.kt
Outdated
Show resolved
Hide resolved
feature/setting/src/main/java/com/droidknights/app2023/feature/setting/SettingScreen.kt
Outdated
Show resolved
Hide resolved
| shape = RoundedCornerShape(32.dp), | ||
| color = Color(0xFFFFFFFF), | ||
| shadowElevation = 2.dp, | ||
| ) { |
There was a problem hiding this comment.
카드 UI는 공통으로 관리하면 어떨까요? 꼭 이 PR이 아니여도 됩니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Overview (Required)
Issue
device-2023-07-20-235615.mp4