About calculating how many months are the difference between two times

[SFLAQiu]

Hello,

About the difference between the two time months, the calculation output is 1 month

s := "2024-10-11"
e := "2024-11-10"
fmt.Println(carbon.Parse(s).DiffAbsInDays(carbon.Parse(e)))
fmt.Println("carbon v2 = ", carbon.Parse(s).DiffInMonths(carbon.Parse(e)))

// print
// 30
// carbon v2 =  1

PHP carbon calculation output: 0 month difference
PHP carbon

echo Carbon::parse("2024-10-11")->diffInMonths("2024-11-10");

// print
// 0

golang version: such as 1.20
carbon version: such as 2.4.1

problem
I personally feel that php carbon's calculation is reasonable, and if the natural month does not meet a month, it should be 0, rather than judging by 28 to return 0 ，Is there a problem with this calculation? Does it need fixing?

func (c Carbon) DiffInMonths(carbon ...Carbon) int64 {
	end := c.Now()
	if c.IsSetTestNow() {
		end = CreateFromTimestampNano(c.testNow, c.Location())
	}
	if len(carbon) > 0 {
		end = carbon[0]
	}
	if c.DiffAbsInDays(end) < 28 {
		return 0
	}
	startYear, startMonth, _ := c.Date()
	endYear, endMonth, _ := end.Date()
	diffYear, diffMonth := endYear-startYear, endMonth-startMonth
	return int64(diffYear*MonthsPerYear + diffMonth)
}

Thanks!

[gouguoyin]

I will compare the PHP version of Carbon

[gouguoyin]

v2.5.0 has been fixed and released, the unit test is as follows

carbon/difference_unit_test.go

Line 1051 in e7c6c67

func TestCarbon_Issue255(t *testing.T) {