Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lang: added ms-MY.json for Bahasa Malaysia in Malaysia (country) #157

Merged
merged 1 commit into from
Oct 31, 2022
Merged

lang: added ms-MY.json for Bahasa Malaysia in Malaysia (country) #157

merged 1 commit into from
Oct 31, 2022

Conversation

hollowaykeanho
Copy link
Contributor

Since the i18n language is missing of Bahasa Malaysia for Malaysia while our other native languages (English [en], and Simplified Chinese [zh-CN]) are available, I, as a Malaysian who understands all these languages shall contribute the missing piece.

The language code is 'ms' but 'my' country code is required as the Bahasa Malaysia language itself is known closely related across the South East Asia coutries (variations in different countries like Singapore and Brunei). The only exception is Bahasa Indonesia where it has its own code (id).

This patch adds ms-my.json for Bahasa Malaysia specifically for Malaysia in South East Asia.

Signed-off-by: (Holloway) Chew, Kean Ho hollowaykeanho@gmail.com

@codecov-commenter
Copy link

Codecov Report

Base: 99.89% // Head: 99.89% // No change to project coverage 👍

Coverage data is based on head (a27ee4b) compared to base (774f205).
Patch has no changes to coverable lines.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #157   +/-   ##
=======================================
  Coverage   99.89%   99.89%           
=======================================
  Files          18       18           
  Lines        2901     2901           
=======================================
  Hits         2898     2898           
  Misses          2        2           
  Partials        1        1           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@gouguoyin
Copy link
Collaborator

According to the name code standards of countries and regions in the world, I think it is better to name my-MS.json,such as 'zh-CN', 'en-CA'

@hollowaykeanho
Copy link
Contributor Author

Noted. Updating it..

Since the i18n language is missing of Bahasa Malaysia for Malaysia
while our other native languages (English [en], and Simplified Chinese
[zh-CN]) are available, I, as a Malaysian who understands all these
languages shall contribute the missing piece.

The language code is 'ms' but 'MY' country code is required as the
Bahasa Malaysia language itself is known closely related across the
South East Asia coutries (variations in different countries like
Singapore and Brunei). The only exception is Bahasa Indonesia where
it has its own code (id).

This patch adds ms-MY.json for Bahasa Malaysia specifically for
Malaysia in South East Asia.

Signed-off-by: (Holloway) Chew, Kean Ho <hollowaykeanho@gmail.com>
@gouguoyin
Copy link
Collaborator

It is my-MS.json, not ms-MY.json, the country code should be put first.

@hollowaykeanho
Copy link
Contributor Author

hollowaykeanho commented Oct 31, 2022

I'm confused. The language is ms, country code is MY. If we follow the example above:

  1. zh-CN, it's Language zh (Simplified Chinese), CN is China.
  2. en-CA, it's Language en (English), CA is Canada.

We're still following ISO 639 (e.g. https://www.venea.net/web/culture_code) right? Please double confirm. I can change it as per your request.

@gouguoyin
Copy link
Collaborator

I'm confused. The language is ms, country code is MY. If we follow the example above:

  1. zh-CN, it's Language zh (Simplified Chinese), CN is China.
  2. en-CA, it's Language en (English), CA is Canada.

We're still following ISO 639 (e.g. https://www.venea.net/web/culture_code) right? Please double confirm. I can change it as per your request.

Sorry, you are right.

@gouguoyin gouguoyin merged commit 3cedcc1 into dromara:master Oct 31, 2022
@hollowaykeanho hollowaykeanho changed the title lang: added ms-my.json for Bahasa Malaysia in Malaysia (country) lang: added ms-MY.json for Bahasa Malaysia in Malaysia (country) Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants