Initial implementation #1
Conversation
|
|
||
| RUN apk add --no-cache git nodejs nodejs-npm yarn | ||
| RUN npm install -g npm@latest \ | ||
| npm install -g donny-dont/greenkeeper-lockfile#feat/drone-ci |
There was a problem hiding this comment.
Waiting on greenkeeperio/greenkeeper-lockfile#141 to merge before changing the endpoint.
Gopkg.toml
Outdated
| @@ -0,0 +1,38 @@ | |||
| # Gopkg.toml example | |||
There was a problem hiding this comment.
We have dropped these comments from Gopkg.toml
| @@ -0,0 +1,62 @@ | |||
| # drone-greenkeeper | |||
|
|
|||
| [](http://beta.drone.io/drone-plugins/drone-greenkeeper) | |||
There was a problem hiding this comment.
Please add all badges, including discourse and stackoverflow.
main.go
Outdated
| "github.com/urfave/cli" | ||
| ) | ||
|
|
||
| var build = "0" // build number set at compile-time |
There was a problem hiding this comment.
Add the build number and version.
main.go
Outdated
| app.Name = "npm plugin" | ||
| app.Usage = "npm plugin" | ||
| app.Action = run | ||
| app.Version = fmt.Sprintf("1.0.0+%s", build) |
There was a problem hiding this comment.
Use the build number and version from above, it will be set by drone tags.
main.go
Outdated
| cli.BoolFlag{ | ||
| Name: "github_token", | ||
| Usage: "Github token", | ||
| EnvVar: "PLUGIN_GITHUB_TOKEN,GREENKEEPER_GITHUB_TOKEN", |
There was a problem hiding this comment.
Maybe also add GITHUB_TOKEN since it's common for github auth?
plugin.go
Outdated
| log.Info("Anonymous NPM credentials are being used") | ||
| } | ||
|
|
||
| var cmds []*exec.Cmd |
There was a problem hiding this comment.
Why this slice? Just directly execute one of the 2 commands.
plugin.go
Outdated
| } | ||
|
|
||
| // See if authentication is required | ||
| if len(p.Config.Username) > 0 || len(p.Config.Token) > 0 { |
There was a problem hiding this comment.
Why do so many people check the length of strings? Just string == "" :)
|
@tboerger I think its ready for a final review. |
| // uploadCommand runs greenkeeper-lockfile-upload. | ||
| func uploadCommand(gk Greenkeeper, build Build) *exec.Cmd { | ||
| cmd := exec.Command("greenkeeper-lockfile-upload") | ||
| cmd.Env = append(droneEnvironment(build), greenkeeperEnvironment(gk)...) |
There was a problem hiding this comment.
So just a heads up with this. The greenkeeper-lockfile stuff expects certain environment variables to be present. One piece of that is stuff detected when it finds that its in the Drone CI environment. The other piece of that is config for the actual commands.
Idea was to just jam all this into an environment in the command rather than appending to the local environment variables.
|
The secrets are already added? |
Here is an implementation of a drone plugin that uses greenkeeper-lockfile. Greenkeeper is a way to keep NPM dependencies up to date and this particular repository is used to keep lockfiles up to date as well. Its used pretty heavily in the JS community and has an enterprise offering so it'd probably be a good thing to support it all.
@bradrydzewski @tboerger it needs to be added to the hub.