Add support for refs to BuildLast #59
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
tboerger
approved these changes
Dec 7, 2020
|
ping |
1 similar comment
|
ping |
|
This is the main (remaining) reason we have to maintain our fork at https://github.com/owncloud-ci/drone-cli |
|
ping? |
| @@ -266,7 +266,11 @@ func (c *client) BuildLast(owner, name, branch string) (*Build, error) { | |||
| out := new(Build) | |||
| uri := fmt.Sprintf(pathBuild, c.addr, owner, name, "latest") | |||
| if branch != "" { | |||
| uri += "?branch=" + branch | |||
| if strings.HasPrefix(branch, "refs/") { | |||
| uri += "?ref=" + branch | |||
There was a problem hiding this comment.
I think it would be cleaner to create a new function BuildLastRef and call the parameter ref. This change still uses "branch" which isn't as clear to read.
There was a problem hiding this comment.
Also with this change the comment is no longer correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.