Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spelling #427

Merged
merged 11 commits into from
Jan 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
**Implemented enhancements:**

- fix low hanging lint issues [\#425](https://github.com/drone/drone-ui/pull/425) ([d1wilko](https://github.com/d1wilko))
- \(maint\) document the release proceedure [\#421](https://github.com/drone/drone-ui/pull/421) ([tphoney](https://github.com/tphoney))
- \(maint\) document the release procedure [\#421](https://github.com/drone/drone-ui/pull/421) ([tphoney](https://github.com/tphoney))
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some projects don't like changing changelogs. Happy to drop...


**Fixed bugs:**

Expand Down Expand Up @@ -166,7 +166,7 @@

**Fixed bugs:**

- show error and console logs for buld steps [\#387](https://github.com/drone/drone-ui/pull/387) ([d1wilko](https://github.com/d1wilko))
- show error and console logs for build steps [\#387](https://github.com/drone/drone-ui/pull/387) ([d1wilko](https://github.com/d1wilko))

**Merged pull requests:**

Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ docker run -it --rm -v "$(pwd)":/usr/local/src/your-app githubchangeloggenerator

You can generate a token by logging into your GitHub account and going to Settings -> Personal access tokens.

Next we tag the PR's with the fixes or enhancements labels. If the PR does not fufil the requirements, do not add a label.
Next we tag the PR's with the fixes or enhancements labels. If the PR does not fulfil the requirements, do not add a label.

Run the changelog generator again with the future version according to semver.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,14 +37,14 @@ const useLogsActionTypes = {
setIsLoading: ACTION_LIST.UPDATE_ARE_LOGS_LOADING,
};

const stepDefferedLogsStates = [
const stepDeferredLogsStates = [
'running',
'pending',
'skipped',
'waiting_on_dependencies',
];

const stageDefferedLogsStates = stepDefferedLogsStates.slice(1);
const stageDeferredLogsStates = stepDeferredLogsStates.slice(1);

export default function LogViewConsoleManager(props) {
const {
Expand All @@ -68,8 +68,8 @@ export default function LogViewConsoleManager(props) {
state.compState !== STATES.STREAM_ON
&& !!state.stageStatus
&& !!state.stepData.status
&& !stageDefferedLogsStates.includes(state.stageStatus)
&& !stepDefferedLogsStates.includes(state.stepData.status),
&& !stageDeferredLogsStates.includes(state.stageStatus)
&& !stepDeferredLogsStates.includes(state.stepData.status),
);

// logs stream
Expand Down
2 changes: 1 addition & 1 deletion src/components/shared/modal/modal.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ const Modal = ({
} else {
window.document.body.style.overflow = 'unset';
}
return () => window.document.body.style.oveflow = 'unset';
return () => window.document.body.style.overflow = 'unset';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Notable

}, [isShowing]);
if (isShowing) {
return ReactDOM.createPortal(
Expand Down
2 changes: 1 addition & 1 deletion src/hooks/store.js
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ export const useStore = create((set, get) => ({
}

// update the state of the store to indicate the
// request to fetch repositorie has been fired,
// request to fetch repository has been fired,
// which prevents subsequent calls.
set((state) => ({
...state,
Expand Down
2 changes: 1 addition & 1 deletion src/pages/build/build.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ export default function Build({ user, userIsAdminOrHasWritePerm }) {
}
}, [data, isError, isLoading, stage]);

// sort individual steps card data into a managable array
// sort individual steps card data into a manageable array
const cardsData = data?.stages?.reduce((cardDataAcc, stageData) => {
const stageCardData = stageData?.steps?.reduce((stageDataAcc, stepData) => {
if (stepData.schema) {
Expand Down
4 changes: 2 additions & 2 deletions src/pages/builds/builds.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export default function Builds({ repo }) {
const { params: { namespace, name }, url } = useRouteMatch();
const history = useHistory();

// if repo is inactive, redirect to settigns where
// if repo is inactive, redirect to settings where
// user can proceed with repo activation
useLayoutEffect(() => {
if (!isRepoActive) {
Expand Down Expand Up @@ -85,7 +85,7 @@ Builds.propTypes = {

Builds.defaultProps = {
repo: {
actice: undefined,
active: undefined,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notable

counter: undefined,
},
};
2 changes: 1 addition & 1 deletion src/pages/home/home.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,7 @@ export default function Home() {
useEffect(() => {
if (syncError || viewerError) {
setContext({ ...context, isAccSyncing: false });
showError('Sync error has occured, please, try again');
showError('Sync error has occurred, please, try again');
console.error('Sync error:', syncError?.message || viewerError?.message); // eslint-disable-line no-console
}
}, [syncError, viewerError, showError, context, setContext]);
Expand Down
2 changes: 1 addition & 1 deletion src/pages/not-found/not-found.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ export default function NotFound({ user }) {
<NotFoundIcon />
<p className={cx('note')}>
<span>We are sorry, the resource you requested cannot be found.</span>
<sub>That&aposs all we know.</sub>
<sub>That&apos;s all we know.</sub>
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't strictly necessary, but it's nicer to not rely on this feature of the html parser...

</p>
{!user && (
<Button
Expand Down
2 changes: 1 addition & 1 deletion src/pages/welcome/welcome.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ export default function Welcome() {
} else {
error = (
<div className={cx('error')}>
{parseQuery(search)?.message ?? 'An error occured during login attempt, please, try again'}
{parseQuery(search)?.message ?? 'An error occurred during login attempt, please, try again'}
</div>
);
}
Expand Down