[PL-26239]: fix for list response

[bhavya181]

response schema for listUserRepositries and listAppnstallations was different, and that's why it was throwing error, so changes the output.
Tested with writing integartion test with my credentials, now, its working fine.

[mohitg0795]

From what I understand, it makes the struct public. Why do we need to make it public if all references are from same package/file?
Sorry, I may be naive here, just trying to understand its impact

[bhavya181]

json unmarshal and marshal only works when name of struct start with capital letter

[mohitg0795]

Oh interesting. Thanks for the info.

[tphoney]

https://github.com//pull/219 repositories should be lower case as @mohitg0795 said

[bhavya181]

but then, RepositoryListResponse will not be able to map to Repository struct as it does not unmarshal that struct

[bhavya181]

Can you suggest any other method, so that it will map correctly

[tphoney]

can you show me where it doesnt work, the unit tests passed and it unmarshalled successfully

if you look at the do method for all drivers, it marshalls / unmarshalls without all of the structs. The other structs all start with a lowercase letter.

[bhavya181]

ya, I have changed them now

[tphoney]

https://github.com//pull/219 repositories should be lower case as @mohitg0795 said

[tphoney]

should start with a lowercase letter

[bradrydzewski]

agree this should be lowercase. Also we do not suffix with Response so it should be repositoryList instead. If this package already has a repositoryList struct, you could alternative use the name repositoryListByInstallation.

[bhavya181]

changed

[bradrydzewski]

The repository struct should never be exposed as public, it should be kept private and converted to scm.Repository. The purpose of this library is to convert vendor-specific structures to common abstractions. The scm.Repository is the common abstraction that must be used.

If the response structure is different, you should create a new repositoryList structure instead. Then you would create a convertRepositoryListByInstallation function that converts the repositories in the repositoryList to a []scm.Repository structure.