(feat) harness, fix create branch, PR calls

scm/driver/harness/git.go

@@ -21,8 +21,11 @@ type gitService struct {
 func (s *gitService) CreateBranch(ctx context.Context, repo string, params *scm.ReferenceInput) (*scm.Response, error) {
 	harnessURI := buildHarnessURI(s.client.account, s.client.organization, s.client.project, repo)
 	path := fmt.Sprintf("api/v1/repos/%s/branches", harnessURI)
-	out := new(branch)
-	return s.client.do(ctx, "GET", path, nil, out)
+	in := &branchInput{
+		Name:   params.Name,
+		Target: params.Sha,
+	}
+	return s.client.do(ctx, "POST", path, in, nil)
 }
 
 func (s *gitService) FindBranch(ctx context.Context, repo, name string) (*scm.Reference, *scm.Response, error) {
@@ -106,6 +109,10 @@ type (
 		Sha     string `json:"sha"`
 		Title   string `json:"title"`
 	}
+	branchInput struct {
+		Name   string `json:"name"`
+		Target string `json:"target"`
+	}
 	branch struct {
 		Commit struct {
 			Author struct {

scm/driver/harness/git_test.go

@@ -173,3 +173,37 @@ func TestListBranches(t *testing.T) {
 		t.Log(diff)
 	}
 }
+
+func TestCreateBranch(t *testing.T) {
+
+	defer gock.Off()
+
+	gock.New(gockOrigin).
+		Post("/gateway/code/api/v1/repos/px7xd_BFRCi-pfWPYXVjvw/default/codeciintegration/thomas/+/branches").
+		Reply(200).
+		Type("application/json").
+		File("testdata/branch.json")
+
+	client, _ := New(gockOrigin, harnessOrg, harnessAccount, harnessProject)
+	client.Client = &http.Client{
+		Transport: &transport.Custom{
+			Before: func(r *http.Request) {
+				r.Header.Set("x-api-key", harnessPAT)
+			},
+		},
+	}
+	input := &scm.ReferenceInput{
+		Name: "test",
+		Sha:  "e8ef0374ca0cee8048e94b28eaf0d9e2e2515a14",
+	}
+	result, err := client.Git.CreateBranch(context.Background(), harnessRepo, input)
+	if err != nil {
+		t.Error(err)
+		return
+	}
+
+	if result.Status != 200 {
+		t.Errorf("Unexpected Results")
+	}
+
+}

scm/driver/harness/issue.go

@@ -6,7 +6,6 @@ package harness
 
 import (
 	"context"
-	"time"
 
 	"github.com/drone/go-scm/scm"
 )
@@ -25,17 +24,14 @@ func (s *issueService) FindComment(ctx context.Context, repo string, index, id i
 
 func (s *issueService) List(ctx context.Context, repo string, opts scm.IssueListOptions) ([]*scm.Issue, *scm.Response, error) {
 	return nil, nil, scm.ErrNotSupported
-
 }
 
 func (s *issueService) ListComments(ctx context.Context, repo string, index int, opts scm.ListOptions) ([]*scm.Comment, *scm.Response, error) {
 	return nil, nil, scm.ErrNotSupported
-
 }
 
 func (s *issueService) Create(ctx context.Context, repo string, input *scm.IssueInput) (*scm.Issue, *scm.Response, error) {
 	return nil, nil, scm.ErrNotSupported
-
 }
 
 func (s *issueService) CreateComment(ctx context.Context, repo string, index int, input *scm.CommentInput) (*scm.Comment, *scm.Response, error) {
@@ -57,91 +53,3 @@ func (s *issueService) Lock(ctx context.Context, repo string, number int) (*scm.
 func (s *issueService) Unlock(ctx context.Context, repo string, number int) (*scm.Response, error) {
 	return nil, scm.ErrNotSupported
 }
-
-//
-// native data structures
-//
-
-type (
-	// gitea issue response object.
-	issue struct {
-		ID          int       `json:"id"`
-		Number      int       `json:"number"`
-		User        user      `json:"user"`
-		Title       string    `json:"title"`
-		Body        string    `json:"body"`
-		State       string    `json:"state"`
-		Labels      []string  `json:"labels"`
-		Comments    int       `json:"comments"`
-		Created     time.Time `json:"created_at"`
-		Updated     time.Time `json:"updated_at"`
-		PullRequest *struct {
-			Merged   bool        `json:"merged"`
-			MergedAt interface{} `json:"merged_at"`
-		} `json:"pull_request"`
-	}
-
-	// gitea issue request object.
-	issueInput struct {
-		Title string `json:"title"`
-		Body  string `json:"body"`
-	}
-
-	// gitea issue comment response object.
-	issueComment struct {
-		ID        int       `json:"id"`
-		HTMLURL   string    `json:"html_url"`
-		User      user      `json:"user"`
-		Body      string    `json:"body"`
-		CreatedAt time.Time `json:"created_at"`
-		UpdatedAt time.Time `json:"updated_at"`
-	}
-
-	// gitea issue comment request object.
-	issueCommentInput struct {
-		Body string `json:"body"`
-	}
-)
-
-//
-// native data structure conversion
-//
-
-func convertIssueList(from []*issue) []*scm.Issue {
-	to := []*scm.Issue{}
-	for _, v := range from {
-		to = append(to, convertIssue(v))
-	}
-	return to
-}
-
-func convertIssue(from *issue) *scm.Issue {
-	return &scm.Issue{
-		Number:  from.Number,
-		Title:   from.Title,
-		Body:    from.Body,
-		Link:    "", // TODO construct the link to the issue.
-		Closed:  from.State == "closed",
-		Author:  *convertUser(&from.User),
-		Created: from.Created,
-		Updated: from.Updated,
-	}
-}
-
-func convertIssueCommentList(from []*issueComment) []*scm.Comment {
-	to := []*scm.Comment{}
-	for _, v := range from {
-		to = append(to, convertIssueComment(v))
-	}
-	return to
-}
-
-func convertIssueComment(from *issueComment) *scm.Comment {
-	return &scm.Comment{
-		ID:      from.ID,
-		Body:    from.Body,
-		Author:  *convertUser(&from.User),
-		Created: from.CreatedAt,
-		Updated: from.UpdatedAt,
-	}
-}