app/dynamic_node_id: avoid spurious reallocation #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let SQLite verify that for us instead of silently corrupting itself.
tpwrules
force-pushed
the
pr/dna-realloc-fix
branch
from
4449bc1 to
2d93601
Compare
|
LGTM, test with AM32 |
Only set a None unique ID in the DNA database if there's no existing unique ID for the node ID and the node's unique ID is not available. This prevents erasing an existing allocation and causing the node to be allocated another ID, while still allowing the node ID to be reserved if a unique ID never becomes available.
tpwrules
force-pushed
the
pr/dna-realloc-fix
branch
from
2d93601 to
43b7025
Compare
|
Testing with AM32, 10 reboots, ESC panel open so we go to main firmware:
Quite confident this is fixed now. |
tridge
approved these changes
Nov 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only set a None unique ID in the DNA database if there's no existing unique ID for the node ID and the node's unique ID is not available. This prevents erasing an existing allocation and causing the node to be allocated another ID, while still allowing the node ID to be reserved if a unique ID never becomes available.
Tested and this seems to fix the issue, though this seems very likely to happen with AM32 and I don't have my AM32 hardware available this exact moment so I'm not 1000% confident yet.