Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature for adding keys by environment variables #107

Merged
merged 1 commit into from
Dec 5, 2018

Conversation

vaithak
Copy link
Contributor

@vaithak vaithak commented Oct 20, 2018

Fixes #104 .

@vaithak
Copy link
Contributor Author

vaithak commented Oct 25, 2018

@diwakergupta Please review my PR.

cmd/root.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@diwakergupta diwakergupta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately this breaks the current build system for dbxcli -- see how credentials are supplied at build-time via build.sh. Can you move updating all these to init instead?

@vaithak
Copy link
Contributor Author

vaithak commented Nov 10, 2018

@diwakergupta I have made the requested changes, now the keys can be accessed through env variables without build failure in official release. Please review my PR.

@diwakergupta diwakergupta merged commit 31654c9 into dropbox:master Dec 5, 2018
@vaithak vaithak deleted the envKeys branch December 7, 2018 08:39
@clarkewd
Copy link

Thanks for adding this feature! I've looked over the changes and also the code in root.go, and read the comments here and on #104

I'm still a little confused though. Is it possible to continue to use the default app keys (i.e. not create my own dropbox app) and then use either the web authentication response or the data from the ~/.config/dbxcli/auth.json file set as an environmental variable instead of using the config file?

I've tried it with both DROPBOX_PERSONAL_APP_KEY and DROPBOX_PERSONAL_APP_SECRET but this doesn't seem like the right place for it...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide credentials thru environment variable?
3 participants