Update Golumns package #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -62,5 +63,9 @@ func numberOfRows(numberOfRows, numberOfNames int) int { | |||
| } | |||
|
|
|||
| func reverse(input []int) []int { | |||
There was a problem hiding this comment.
Why not just use sort.Reverse instead of your own helper? https://golang.org/pkg/sort/#Reverse
There was a problem hiding this comment.
It certainly is a little sloppy to have a helper function do it, but I chose it for readability reasons. The sort.Reverse function requires an interface type, so I'd have to do conversions with sort.IntSlice which I wasn't very happy with. I'll take another look to see if it's less complicated than I originally thought it was.
|
Will go ahead and merge, but Golumns should just use stdlib where possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found an issue in golumns causing some other use cases to panic, didn't have the issue with dbxcli, but I definitely think it's important to vendor in this change.