Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change deprecated .buffer() to .arrayBuffer() #1137

Open
MariusVB opened this issue Apr 16, 2024 · 5 comments · May be fixed by #1138
Open

Change deprecated .buffer() to .arrayBuffer() #1137

MariusVB opened this issue Apr 16, 2024 · 5 comments · May be fixed by #1138

Comments

@MariusVB
Copy link

res.buffer().then((data) => resolve(data));

The .buffer() will be removed in upcoming node versions. On node 20, I'm getting a deprecation error at every file download...

@greg-db
Copy link
Contributor

greg-db commented Apr 16, 2024

Thanks for the report! I'll ask the team to update that.

@decovicdev decovicdev linked a pull request Apr 23, 2024 that will close this issue
7 tasks
@MariusVB
Copy link
Author

Are you a bot @greg-db ?

@greg-db
Copy link
Contributor

greg-db commented Apr 29, 2024

@MariusVB No, I am not a bot. I am a real person monitoring these issues.

@toddjudd
Copy link

@greg-db I created and closed an issue to make the same fix. any chance this gets merged? I'm monkey patching for the time being.

@greg-db
Copy link
Contributor

greg-db commented Sep 23, 2024

@toddjudd Thanks for the note. This is still open with the team but I don't have an update on it yet. I'll follow up here once I do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants