Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change deprecated .buffer() to .arrayBuffer() #1137

Open
MariusVB opened this issue Apr 16, 2024 · 7 comments · May be fixed by #1138
Open

Change deprecated .buffer() to .arrayBuffer() #1137

MariusVB opened this issue Apr 16, 2024 · 7 comments · May be fixed by #1138

Comments

@MariusVB
Copy link

dropbox-sdk-js/src/response.js

Line 51 in 6bfaf89

res.buffer().then((data) => resolve(data));

The .buffer() will be removed in upcoming node versions. On node 20, I'm getting a deprecation error at every file download...
@greg-db
Copy link
Contributor

greg-db commented Apr 16, 2024

Thanks for the report! I'll ask the team to update that.

@decovicdev decovicdev linked a pull request Apr 23, 2024 that will close this issue
Open
7 tasks
@MariusVB
Copy link
Author

Are you a bot @greg-db ?

@greg-db
Copy link
Contributor

greg-db commented Apr 29, 2024

@MariusVB No, I am not a bot. I am a real person monitoring these issues.

@toddjudd toddjudd mentioned this issue Sep 21, 2024
Closed
@toddjudd
Copy link

@greg-db I created and closed an issue to make the same fix. any chance this gets merged? I'm monkey patching for the time being.

@greg-db
Copy link
Contributor

greg-db commented Sep 23, 2024

@toddjudd Thanks for the note. This is still open with the team but I don't have an update on it yet. I'll follow up here once I do.

@binajmen
Copy link

binajmen commented Jan 5, 2025

Hi @greg-db, can you bump this ticket up to the team? In its current state, this library is not usable with Bun. buffer() has been deprecated in favour of arrayBuffer(). It is only a one line change, I'm not sure what is blocking here..

dropbox-sdk-js/src/response.js

Line 51 in 6bfaf89

res.buffer().then((data) => resolve(data));

@alyx-db
Copy link

alyx-db commented Jan 6, 2025

@binajmen I've made an additional note on this issue with the team. We'll follow up here once there is an update available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix fetch erros decovicdev/dropbox-sdk-js
5 participants
@greg-db @toddjudd @binajmen @MariusVB @alyx-db