Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make ci runnable from main #954

Merged
merged 1 commit into from
May 3, 2022
Merged

make ci runnable from main #954

merged 1 commit into from
May 3, 2022

Conversation

rogebrd
Copy link
Contributor

@rogebrd rogebrd commented May 3, 2022

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • SDK Code Change
  • Example/Test Code Change

Validation

  • Does npm test pass?
  • Does npm run build pass?
  • Does npm run lint pass?

eugeneyche
eugeneyche approved these changes May 3, 2022
View reviewed changes
Copy link
Contributor

@eugeneyche eugeneyche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rogebrd rogebrd merged commit 1f317a0 into main May 3, 2022
@rogebrd rogebrd deleted the update_tests branch May 3, 2022 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eugeneyche eugeneyche eugeneyche approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rogebrd @eugeneyche