Skip to content

use builtin_type if it exists, otherwise named_type #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

shawnwall
Copy link
Contributor

resolves #232

  • mypy .930 deprecated builtin_type in favor of named_type, but brought it back in .931
  • this patch uses hasattr() to check for existence of builtin_type, and if not present, use named_type for future proofing code

@ilevkivskyi ilevkivskyi merged commit 80f8932 into dropbox:master Jan 26, 2022
@shawnwall shawnwall deleted the mypy-builtin-named-type-futureproof branch January 26, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mypy 0.930 breaks the sqlmypy plugin with an INTERNAL ERROR
2 participants