Fix hash and client var name collision errors #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaronsky
approved these changes
Aug 27, 2024
julianlocke
force-pushed
the
fix-unreachable-code
branch
from
018e3d6
to
2f6edd7
Compare
julianlocke
force-pushed
the
fix-compat-type-name-collisions
branch
from
97f07dc
to
d048dbf
Compare
julianlocke
added a commit
that referenced
this pull request
Aug 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a few new variable names that must be suffixed with
_to avoid collisions in the SwiftyDropbox Objective-C compatibility layer: hash (colliding with the NSObject var) and client (colliding with our own client vars).Checklist
General Contributing
Is This a Code Change?
Validation
tox?