Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add first party Objective-C to Swift SDK RPC migration shim. #350

Merged
merged 8 commits into from
Oct 24, 2024

Conversation

julianlocke
Copy link
Contributor

@julianlocke julianlocke commented Sep 30, 2024

See dropbox/SwiftyDropbox#435 for both output code from these changes and a discussion of them. This code to be deleted post migration.

Checklist

General Contributing

  • Have you read the Code of Conduct and signed the CLA?

Is This a Code Change?

  • Non-code related change (markdown/git settings etc)
  • Code Change
  • Example/Test Code Change

Validation

  • Have you ran tox?
  • Do the tests pass?

@julianlocke julianlocke changed the title [WIP] Add first party Objective-C to Swift SDK migration shim. [WIP] Add first party Objective-C to Swift SDK RPC migration shim. Sep 30, 2024
Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 265 lines in your changes missing coverage. Please review.

Project coverage is 48.45%. Comparing base (40bd164) to head (bd7e81e).

Files with missing lines Patch % Lines
stone/backends/swift.py 0.00% 163 Missing ⚠️
stone/backends/swift_types.py 0.00% 52 Missing ⚠️
stone/backends/swift_client.py 0.00% 38 Missing ⚠️
stone/backends/swift_helpers.py 0.00% 12 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff              @@
##           objc-shim     #350      +/-   ##
=============================================
- Coverage      49.85%   48.45%   -1.40%     
=============================================
  Files             37       37              
  Lines           8778     9031     +253     
  Branches        1891     1963      +72     
=============================================
  Hits            4376     4376              
- Misses          4084     4337     +253     
  Partials         318      318              
Flag Coverage Δ
unit 48.45% <0.00%> (-1.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@julianlocke julianlocke changed the title [WIP] Add first party Objective-C to Swift SDK RPC migration shim. Add first party Objective-C to Swift SDK RPC migration shim. Oct 22, 2024
@julianlocke julianlocke merged commit f33f7c2 into objc-shim Oct 24, 2024
9 of 10 checks passed
@julianlocke julianlocke deleted the objc-shim-init branch October 24, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants