-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add first party Objective-C to Swift SDK RPC migration shim. #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianlocke
changed the title
[WIP] Add first party Objective-C to Swift SDK migration shim.
[WIP] Add first party Objective-C to Swift SDK RPC migration shim.
Sep 30, 2024
julianlocke
force-pushed
the
objc-shim-init
branch
from
October 1, 2024 14:49
10cd387
to
bd7e81e
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## objc-shim #350 +/- ##
=============================================
- Coverage 49.85% 48.45% -1.40%
=============================================
Files 37 37
Lines 8778 9031 +253
Branches 1891 1963 +72
=============================================
Hits 4376 4376
- Misses 4084 4337 +253
Partials 318 318
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
julianlocke
force-pushed
the
objc-shim-init
branch
from
October 1, 2024 15:33
bd7e81e
to
58a1555
Compare
julianlocke
changed the title
[WIP] Add first party Objective-C to Swift SDK RPC migration shim.
Add first party Objective-C to Swift SDK RPC migration shim.
Oct 22, 2024
aaronsky
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See dropbox/SwiftyDropbox#435 for both output code from these changes and a discussion of them. This code to be deleted post migration.
Checklist
General Contributing
Is This a Code Change?
Validation
tox
?