Feat: update service

[dTechLife]

No description provided.

[samuel-videau]

Change to ioredis library instead, always take the most downloaded and maintained libraries (check in leequid-back how it's being used, it s easy)

[dTechLife]

Easy refactor, sounds good.

[samuel-videau]

Ah ioredis is here, why did you need the other library then ?

On leequid-back, REDIS service is as simple as that:

import { Injectable, OnModuleDestroy, OnModuleInit } from '@nestjs/common';
import { LoggerService } from '@libs/logger/logger.service';
import winston from 'winston';
import Redis from 'ioredis';

import { REDIS_KEY } from './redis-keys';
import { REDIS_URI } from '../globals';

@Injectable()
export class RedisService implements OnModuleInit, OnModuleDestroy {
  protected client: Redis;
  protected logger: winston.Logger;

  constructor(protected readonly loggerService: LoggerService) {
    this.logger = loggerService.getChildLogger('RedisService');
  }

  onModuleInit(): void {
    this.client = new Redis(REDIS_URI);
  }

  onModuleDestroy(): void {
    this.client.quit();
  }

  async get(key: REDIS_KEY): Promise<string | null> {
    return this.client.get(key);
  }

  async set(key: REDIS_KEY, value: string): Promise<void> {
    await this.client.set(key, value);
  }

  async setTotalWithdrawals(totalWithdrawals: bigint, checkpoint: number): Promise<void> {
    await this.set(REDIS_KEY.TOTAL_WITHDRAWALS, totalWithdrawals.toString());
    await this.set(REDIS_KEY.WITHDRAWALS_CHECKPOINT, checkpoint.toString());
  }
}

[samuel-videau]

Yeah again, not necessary I guess, only ioredis is enough

[samuel-videau]

What is this used for ? I don t see any usage

[dTechLife]

Husky is used for pre-commit.

[samuel-videau]

?

[dTechLife]

looks like just an extra comma, probably just automated from formatting/saving the file.

[samuel-videau]

Again no need to check parameters if not decoded. If you did all of that yourself, this query would be the same as the fetchNonDecodedTransactionsWithInput, they both do the exact same thing, with almost same tables, but 2 totally different and wrong methods

[samuel-videau]

Try catch and logging should not be done in the DB service but outside

[samuel-videau]

Just look at my existing functions, you should be consistent with what s existing

[dTechLife]

Got it, okay. Looking through and I find functions like this attached code. We should clean these up as well as they are inconsistent as well perhaps, or is there a differentiating factor?

  public async insertTokenHolder(
    tokenHolder: TokenHolderTable, // 'balanceInEth' is not supplied, hence we omit it
    onConflict: 'throw' | 'update' | 'do nothing' = 'throw',
  ): Promise<void> {
    let query = `
          INSERT INTO ${DB_DATA_TABLE.TOKEN_HOLDER} ("holderAddress", "contractAddress", "tokenId", "balanceInWei", "balanceInEth", "holderSinceBlock")
          VALUES ($1, $2, $3, $4, $5, $6)
        `;

    try {
      await this.executeQuery(query, [
        tokenHolder.holderAddress,
        tokenHolder.contractAddress,
        tokenHolder.tokenId,
        tokenHolder.balanceInWei,
        tokenHolder.balanceInEth,
        tokenHolder.holderSinceBlock,
      ]);
    } catch (error) {
      if (onConflict === 'do nothing' && JSON.stringify(error.message).includes('duplicate')) {
        // Do nothing
      } else if (onConflict === 'update' && JSON.stringify(error.message).includes('duplicate')) {
        query = `
          UPDATE ${DB_DATA_TABLE.TOKEN_HOLDER} 
          SET "balanceInWei" = $4, "balanceInEth" = $5
          WHERE "holderAddress" = $1 AND "contractAddress" = $2 
          AND (("tokenId" = $3 AND $3 IS NOT NULL) OR ("tokenId" IS NULL AND $3 IS NULL));
        `;

        await this.executeQuery(query, [
          tokenHolder.holderAddress,
          tokenHolder.contractAddress,
          tokenHolder.tokenId,
          tokenHolder.balanceInWei,
          tokenHolder.balanceInEth,
        ]);
      } else {
        // If some other error occurred, rethrow it
        throw error;
      }
    }
  }

[samuel-videau]

Again no need to check for the event_parameter, only the event without event name

[dTechLife]

If the event params errored last update we should iterate over them again no? The purpose of this is error handling.

[samuel-videau]

Why ?

[dTechLife]

to fix a type error I believe? Does it not make sense logically to you that this is needed here?

[samuel-videau]

What is that ? Why is it used ?

[dTechLife]

This is the dummy logger, like /dev/null in linux it's a black hole to allow throwing out the data. This is required for the ONLY_LOG_SERVICE= env variable for all the undefined services.