Add support for the default shared health check registry name #1095
+146
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the ability to use a shared health check registry across different modules. The managed health check registry is set via the `setDefault` method and then it could be accessible by consumers via the `getDefault` method. This is aligned with `SharedMetricRegistries`, which provides the same functionality.
|
The original idea from @mattnelson in #849 |
jplock
approved these changes
Feb 27, 2017
|
@jplock Does the tests work for you? I get
Cheers. |
|
The tests passed on travis. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the ability to use a shared health check registry across different modules. The managed health check registry is set via the
setDefaultmethod and then it could be accessible by consumers via thegetDefaultmethod.This is aligned with
SharedMetricRegistries, which provides the same functionality.