Skip to content

Conversation

@joschi
Copy link
Member

@joschi joschi commented Jun 4, 2025

This change set has been created using GitHub Copilot as an experiment.

Closes #2167

This change set has been created using GitHub Copilot as an experiment.
@joschi joschi added this to the 5.0.0 milestone Jun 4, 2025
@joschi joschi self-assigned this Jun 4, 2025
@joschi joschi requested review from a team as code owners June 4, 2025 13:10
@joschi
Copy link
Member Author

joschi commented Jun 4, 2025

@mbrannstrom @baharclerode Do you want to weigh in on this?

@joschi joschi linked an issue Jun 4, 2025 that may be closed by this pull request
@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
13.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@mbrannstrom
Copy link

@mbrannstrom Do you want to weigh in on this?

The primary purpose of #2167 was to come to an agreement on the desired behavior (in 2021). Once we knew WHAT to build, then the HOW would be trivial. I could have provided an implementation back in 2021...

@joschi What is the reason to revive this issue now? Do we have a planned release of Metric 5.0 soon?

@joschi
Copy link
Member Author

joschi commented Jun 4, 2025

What is the reason to revive this issue now? Do we have a planned release of Metric 5.0 soon?

We have the following options:

  • Release Dropwizard Metrics 5.0.0 without this. Then changing the format will be (strictly speaking) a breaking change.
  • Release Dropwizard Metrics 5.0.0 with this change for peace of mind.
  • Scrap Dropwizard Metrics 5.0.0 altogether because the demand has frankly been quite low. On the other hand most of the work has already been done.

I wanted to play with GitHub Copilot's agent mode and this issue seemed innocent enough, so here we are. 😅

@joschi joschi merged commit d09ddf1 into release/5.0.x Jun 8, 2025
4 of 5 checks passed
@joschi joschi deleted the experiment-copilot-influxdb-line-protocol branch June 8, 2025 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

MetricName well-defined toString + valueOf(String)

3 participants