ArcIntern should not implement Borrow because it hashes differently

droundy · Apr 10, 2024 · 7e7daa5 · 7e7daa5
1 parent 4add6b5
commit 7e7daa5
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 17 deletions.
diff --git a/Cargo.toml b/Cargo.toml
@@ -1,6 +1,6 @@
 [package]
 name = "internment"
-version = "0.7.5"
+version = "0.8.0"
 authors = ["David Roundy <daveroundy@gmail.com>"]
 edition = "2018"
 

diff --git a/src/arc.rs b/src/arc.rs
@@ -289,12 +289,6 @@ impl<T: ?Sized + Eq + Hash + Send + Sync> Deref for ArcIntern<T> {
     }
 }
 
-impl<T: ?Sized + Eq + Hash + Send + Sync> Borrow<T> for ArcIntern<T> {
-    fn borrow(&self) -> &T {
-        self.as_ref()
-    }
-}
-
 impl<T: ?Sized + Eq + Hash + Send + Sync + Display> Display for ArcIntern<T> {
     fn fmt(&self, f: &mut std::fmt::Formatter) -> Result<(), std::fmt::Error> {
         self.deref().fmt(f)

diff --git a/src/arc_dst.rs b/src/arc_dst.rs
@@ -312,16 +312,6 @@ fn dst_arc_intern_is_clone() {
         ArcIntern<str>: Clone;
 }
 
-#[test]
-fn dst_arc_intern_is_borrow() {
-    // demonstrate that Arc has this ability
-    let map = std::collections::HashMap::<std::sync::Arc<str>, u32>::new();
-    assert!(map.get("dst_arc_intern_is_borrow").is_none());
-
-    let map = std::collections::HashMap::<ArcIntern<str>, u32>::new();
-    assert!(map.get("dst_arc_intern_is_borrow").is_none());
-}
-
 #[test]
 fn dst_arc_intern_is_send_and_sync() {
     struct _Assure