Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sox as a required package for Fedora. #241

Merged
merged 3 commits into from
Jun 13, 2022
Merged

Add sox as a required package for Fedora. #241

merged 3 commits into from
Jun 13, 2022

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jun 12, 2022

While testing with Fedora Rawhide, I found that the compile would fail with the provided README instructions due to sox not being on the system. This PR adds it as a required dependency to avoid compiler errors.

@tmiw
Copy link
Collaborator Author

tmiw commented Jun 12, 2022

@Tyrbiter, I think the instructions are fine now but confirmation would be good.

BTW should I remove the PortAudio instructions for Fedora given that it's basically pipewire only now?

@Tyrbiter
Copy link

OK, I have looked at these changes and I can't see any problems with the overall instructions and necessary packages.

I build freedv using separate rpm builds for codec2 and lpcnet as set up by Richard Shaw KF5OIM, I have now added a Requires: entry for sox into the freedv.spec file I use. I will add a request to make this change in the Redhat bugzilla.

@tmiw
Copy link
Collaborator Author

tmiw commented Jun 13, 2022

OK, I have looked at these changes and I can't see any problems with the overall instructions and necessary packages.

I build freedv using separate rpm builds for codec2 and lpcnet as set up by Richard Shaw KF5OIM, I have now added a Requires: entry for sox into the freedv.spec file I use. I will add a request to make this change in the Redhat bugzilla.

Sounds good, thanks!

@tmiw tmiw merged commit eb74d82 into master Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants