Fixes to allow OSX build to compile and run without crashing #26
Conversation
…s needed to guarantee minimum OSX version of 10.9 and usage of libc++ by wxWidgets.
|
Great work @tmiw - I've asked Mark to test on his machine. It would also be nice to configure Travis to build this to ensure we don't break the OSX build as freedv-gui evolves. |
| # First build and install vanilla codec2 as we need -lcodec2 to build LPCNet | ||
| cd $FREEDVGUIDIR | ||
| git clone https://github.com/drowe67/codec2.git | ||
| cd codec2 && git checkout master && git pull |
There was a problem hiding this comment.
@tmiw do we need to clone from tmiw:master here to test this PR?
There was a problem hiding this comment.
I did this (by changing the script in my own local git repo), and it worked.
|
I can confirm that this PR lets me build under OSX! I haven't done any testing of the resultant build, but it does open, so I'd say that's good enough to approve this PR. |
| # First build and install vanilla codec2 as we need -lcodec2 to build LPCNet | ||
| cd $FREEDVGUIDIR | ||
| git clone https://github.com/drowe67/codec2.git | ||
| cd codec2 && git checkout master && git pull |
There was a problem hiding this comment.
I did this (by changing the script in my own local git repo), and it worked.
|
Oops I think I posted a comment to the wrong PR. Here's my test request: https://github.com/drowe67/codec2/tree/master/wav for this build of freedv-gui. |
This is the second part of the needed changes to get OSX builds working again (the first part involves Codec2 changes; that pull request is at https://github.com/drowe67/codec2/pull/66). To do this, build_osx.sh was created as well as various CMake files fixed to ensure that consistent OSX compiler/linker flags are used throughout all prerequisites.