Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update labeling of clipping and BPF options. #319

Merged
merged 5 commits into from
Dec 21, 2022
Merged

Update labeling of clipping and BPF options. #319

merged 5 commits into from
Dec 21, 2022

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Dec 18, 2022

Resolves #317 by updating labeling as suggested:

  1. "700D TX Band Pass Filter" becomes "700D/E TX Band Pass Filter" in the GUI.
  2. "FreeDV 700 Options" becomes "Modem Options".

Further labeling updates will be deferred until changes on Codec2 side occur to enable BPF setting for all OFDM modes.

@tmiw tmiw mentioned this pull request Dec 18, 2022
Closed
@tmiw tmiw merged commit f61d144 into master Dec 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option -> Modem "Clipping" and "Band Pass Filter" applies to all OFDM modes?
1 participant
@tmiw