Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues causing FreeDV 1.4 release candidate to crash #34

Merged
merged 2 commits into from
Dec 25, 2019
Merged

Issues causing FreeDV 1.4 release candidate to crash #34

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3920ec8
removing assert that is firing on Windows machines
drowe67 Nov 18, 2019
7dd8b61
access freedv-gui branches, and updated README
drowe67 Nov 18, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/fdmdv2_main.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4094,8 +4094,6 @@ void txRxProcessing()
fprintf(stderr, " nout: %d\n", nout);
}
ret = codec2_fifo_write(cbData->outfifo1, outsound_card, nout);
// should never fire as we check there is enough room before entering while loop
assert(ret != -1);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually just noticed this on OSX as well (happens the instant I push PTT) and it appears it's related to sample rate mismatches. For instance, my Griffin iMic USB sound card seems to default to 48000Hz while my MacBook Pro's internal sound card defaults to 44100. Setting both to 44100 in the app causes the crash not to occur.

Anyway, I haven't dug too much into the Codec2 end of things but does removing the assertion result in other side effects?

Copy link
Owner Author

@drowe67 drowe67 Dec 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No it's just checking an assumption about how many samples are in a FIFO. The current Windows Beta has been built off this branch, and has been working OK for a several weeks.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. I'm fine with this fix, then. I'll see about building a new OSX image with it as well.

}
}

Expand Down