Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missed captures for pavucontrol related handlers #420

Merged
merged 3 commits into from
Jun 7, 2023

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jun 6, 2023

Resolves #418 by adding some captures that were missed during the initial implementation of PulseAudio/pipewire support.

@tmiw
Copy link
Collaborator Author

tmiw commented Jun 6, 2023

@Tyrbiter, I'm not going to be able to test myself until tonight, but give this a shot and let me know how it goes.

@Tyrbiter
Copy link

Tyrbiter commented Jun 6, 2023

@Tyrbiter, I'm not going to be able to test myself until tonight, but give this a shot and let me know how it goes.

OK, built, installed, tested, changed output device in pavucontrol and then changed it back again, it worked.

More miraculous speedy coding from @tmiw folks :)

@tmiw
Copy link
Collaborator Author

tmiw commented Jun 7, 2023

Looks like this works fine here, will merge up. 👍 Thanks!

@tmiw tmiw merged commit 4e2b363 into master Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possible FreeDV crash when adjusting audio settings with pavucontrol
2 participants