Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust waterfall settings to better visualize 2 Hz fading. #487

Merged
merged 13 commits into from
Jul 31, 2023

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Jul 28, 2023

Resolves #79 and #148 by adjusting some of the waterfall settings to prevent filtering out fast fades. This includes:

  • Adjusting the built-in IIR filter for the waterfall so that newer data is a bigger contribution to the calculated points.
  • Adjusting how new lines are drawn in PlotWaterfall by drawing a MODEM_STATS_NSPEC x 1 temporary image and having wxWidgets resize to the correct width and dy.
  • Use a fixed number of pixels/second to avoid issues with fractional positioning and improper WF scrolling speed.

Additionally, this PR adds the ability to average the spectrum plot across 1-3 samples.

@tmiw tmiw mentioned this pull request Jul 28, 2023
@Tyrbiter
Copy link

This is a nice improvement, seems to reduce CPU load quite a bit too.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 29, 2023

This is a nice improvement, seems to reduce CPU load quite a bit too.

Neat, I wasn't even aiming for lower CPU 👍

@Tyrbiter
Copy link

Would it be possible to have an averaging function on the spectrum display? Maybe allow 1, 2 or 3 sweeps, the new spectrum is a bit noisier and I think it would help to make signals a bit clearer. I am assuming that the waterfall changes can be retained without the spectrum plot affecting those.

@tmiw
Copy link
Collaborator Author

tmiw commented Jul 30, 2023

Would it be possible to have an averaging function on the spectrum display? Maybe allow 1, 2 or 3 sweeps, the new spectrum is a bit noisier and I think it would help to make signals a bit clearer. I am assuming that the waterfall changes can be retained without the spectrum plot affecting those.

I added something that I think might do what you're asking. Let me know how it looks? It seems to smooth things out a bit more here, anyway.

@tmiw tmiw merged commit e61e2e0 into master Jul 31, 2023
@Tyrbiter
Copy link

Tyrbiter commented Aug 1, 2023

Would it be possible to have an averaging function on the spectrum display? Maybe allow 1, 2 or 3 sweeps, the new spectrum is a bit noisier and I think it would help to make signals a bit clearer. I am assuming that the waterfall changes can be retained without the spectrum plot affecting those.

I added something that I think might do what you're asking. Let me know how it looks? It seems to smooth things out a bit more here, anyway.

This is good for me, the only thing is that the averaging setting is not saved, would be nice if it were.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Waterfall maintenance
2 participants