-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More column sizing adjustments #646
Conversation
@barjac, hopefully this works for you? |
I built and installed this latest version. There are some issues. The 2 Mode columns are different widths for some reason. The SNR column is a bit too wide. The Locator column is now wider than the new maximum 6 characters displayed. The distance column could be narrowed a little, 5 digits should be sufficient. I appreciate how difficult this is, it may also be affected by font sizes. |
This seems much better, and apologies for forgetting about the space used by the column sorting indicator. I don't think much improvement is possible now. |
I agree, much improved :) While on the looks of the GUI, could a 'dark mode' be made available from within the program? I can use the system theme in plasma5 on x86_64 but changing the theme in LXQT DE on the RPi4 does not affect FreeDV. Maybe I just can't find the correct setting. |
If you're using wxWidgets 3.2, it should automatically detect the OS/dev environment's setting for that. Seems to on Ubuntu with GNOME, anyway, albeit not 100% perfect. For example, when starting in dark mode: and then switching to light mode in the GNOME settings: |
BTW, I just checked in a change that should make dark->light mode transitions work a bit better in the FreeDV Reporter window (at least on Linux and maybe macOS; Windows does have some separate logic for that control in wxWidgets so it might not have had the problem in the first place). |
This PR performs the following to address feedback posted at #644 (comment):