Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate soxr as a replacement resampling library #779

Closed
wants to merge 18 commits into from

Conversation

tmiw
Copy link
Collaborator

@tmiw tmiw commented Dec 4, 2024

Continuation of PR #776 with the changes needed to switch from libsamplerate to soxr as the resampler.

TODO:

  • Develop test procedure for comparing soxr with libsamplerate
  • Test soxr at various quality levels against existing libsamplerate code
  • TBD

@drowe67
Copy link
Owner

drowe67 commented Dec 10, 2024

@tmiw - I do not feel there is any justification for this PR - and the decision to do this work should be a decision made by the PLT.

Resamplers are not magic and we are not going to get significant improvements by swapping libraries in and out. A much better approach is our own, well understood resamplers, as per #777.

@tmiw
Copy link
Collaborator Author

tmiw commented Dec 10, 2024

We can close, but I'd say not to delete this branch in case we decide to start working on #777 at some point in the future and find that the soxr work already done may be useful (which might not be if we find that another strategy is better, of course).

@tmiw tmiw closed this Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants