Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: added the option to have a search in the select component #131

Merged
merged 8 commits into from
Mar 11, 2024

Conversation

Ftarganski
Copy link
Contributor

@Ftarganski Ftarganski commented Mar 6, 2024

CU-86drf4vj4

📝 Description

  • Added the option to have a search in the select component

🚀 Why is this change required and behavior changes

  • The select component will have the option of having an internal search to search among the available values.
  • Search is optional within select

💣 Is this a breaking change:

  • Yes

  • No

  • To use search within select, two new parameters must be configured within Select.Root.
    <Select.Root enableSearch={true} searchPlaceholder="Here is the Search placeHolder" >

  • By default enableSearch is false!

📝 Additional Information

Checklist

  • I've created/modified some component
  • I've created/modified the component's stories
  • I've created/modified the component's tests

@github-actions github-actions bot added the feature New Features and cool stuff label Mar 6, 2024
@Ftarganski Ftarganski changed the title Adicionar opção de search no select Feat: added the option to have a search in the select component Mar 11, 2024
@Ftarganski Ftarganski marked this pull request as ready for review March 11, 2024 19:52
@Ftarganski Ftarganski merged commit de3d5bc into main Mar 11, 2024
0 of 3 checks passed
@Ftarganski Ftarganski deleted the feat-select-text branch March 11, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New Features and cool stuff
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants