Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix pvc deletetion #187

Merged
merged 4 commits into from
May 15, 2021
Merged

fix pvc deletetion #187

merged 4 commits into from
May 15, 2021

Conversation

AdheipSingh
Copy link
Contributor

@AdheipSingh AdheipSingh commented May 14, 2021

Fixes #186

Description


This PR has:

  • been tested on a real K8S cluster to ensure creation of a brand new Druid cluster works.
  • been tested for backward compatibility on a real K*S cluster by applying the changes introduced here on an existing Druid cluster. If there are any backward incompatible changes then they have been noted in the PR description.
  • added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader.
  • added documentation for new or modified features or behaviors.

@himanshug ##### Key changed/added files in this PR * `handler.go`

@himanshug himanshug merged commit 4edb0e8 into druid-io:master May 15, 2021
@AdheipSingh
Copy link
Contributor Author

On further debug, i see that in case you have a custom pvc mounted on any of the nodes, the operator wont remove any sts mounted pvc ( somehow thats where i missed out this bug, since i am using custom pvc too )

Regardless, its fine now. I will be working on getting some integration tests on a live k8s cluster. I tried to catch the same error with smoke tests but it cant catch such errors.

@himanshug Do you think we need to cut a release for this bug fix ? since 0.0.6 will have this bug, it might affect users.

@himanshug
Copy link
Member

pushed a patch release 0.0.6.1 , thanks!

@AdheipSingh
Copy link
Contributor Author

@himanshug awesome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using volumeClaimTemplates result in PVCs being deleted before pods come up
2 participants