-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The hook provided by setInfoHook
is called too late
#39
Comments
I agree that having a event before dumping the table would make more sense for DX. when the goal of the hook is to allow printing progress I think we should move it before the dump. in case the hook is used in the wild to do other stuff as well, it might make sense to add another hook, so we don't break BC. |
in case we implent the suggestion in https://github.com/druidfi/mysqldump-php/pull/38/files#r1505546205 the current event could stay after the dump and it should work without a BC break |
@guvra you good with this one now that 1.1.0 was released? |
@back-2-95 Yes, it's working fine, thanks for the new release 👍 |
Hi,
I'm working on a feature for gdpr-dump that displays the dump progress with a progress bar:
Smile-SA/gdpr-dump#113
The goal is to be able to know which tables take a long time to dump when creating a dump file for a very big database.
I'm using the function
setInfoHook
to make the progress bar advance.However, it's not working properly, because the hook is triggered after a table was dumped.
Instead of displaying the name of the table that is being dumped, it displays the name of the previous table.
For this feature to work properly, I either need the hook to be moved before a table is dumped, or another hook to be added.
What do you think would be the best solution?
I can provide a PR.
The text was updated successfully, but these errors were encountered: