1.1.0 features

[back-2-95]

• Inline escape() method to improve performance #34
• Remove unnecessary call_user_func() to be faster #36
• Faster dump by less tiny writes() #37
• Trigger the dump info hook when max buffer length is reached #40

This branch can be installed via Packagist: https://packagist.org/packages/druidfi/mysqldump-php#dev-1.1.0-features

composer require druidfi/mysqldump-php:dev-1.1.0-features

or

composer require "druidfi/mysqldump-php:dev-1.1.0-features as 1.0.2"

[back-2-95]

@staabm as a first step I gathered the PRs as one here. Tests pass and Packagist has a version for testing.

[back-2-95]

@staabm My first test on a Drupal site which also does GDPR transforms on certain fields. I use Orbstack on M1 Pro Mac.

Version 1.0.2: 40s
This branch: 5s

Wow!

[staabm]

Sounds perfect. I will also do some more testing this week

[staabm]

since we are buffering rows into batches with this PR, it might make sense to emit a event at this point in time, so a possible progress indicator could also update when a table dump is in-flight.

otherwise dumping huge tables will not see any progress updates for - in our case - 20-30 minutes.

see also #39

I would propose something like

Suggested change

	$this->write($line . ';' . PHP_EOL);
	$this->write($line . ';' . PHP_EOL);
	($this->infoCallable)('table', ['name' => $tableName, 'rowProgress' => $count]);

[guvra]

Another call before the foreach loop is also needed, otherwise the dump info will display an incorrect table name until the 1st million characters were processed.

Also maybe adding a state instead of rowProgress, e.g.:

Before the start of the foreach:
['name' => $tableName, 'completed' => false, 'rowCount' => 0]

Within the foreach loop:
['name' => $tableName, 'completed' => false, 'rowCount' => $count]

After the foreach loop:
['name' => $tableName, 'completed' => true, 'rowCount' => $count]

[staabm]

valid points. I like your idea more than mine

[staabm]

Would be great this could be merged so I could work on other stuff

[back-2-95]

Hi, I’m in bed with flu or something so my countribution will go to next week 🤒
Lähetetty iPhonesta

[staabm]

All the best. Get well soon

[back-2-95]

New release available https://github.com/druidfi/mysqldump-php/releases/tag/1.1.0

[staabm]

Thank you 🙏

[staabm]

Fyi, the remaining perf bottleneck in pdo->quote() should also be widened with the next php-src release

php/php-src#13440