Use 8x faster mysqldump fork #702
Conversation
config/composer-35.json
Outdated
| @@ -37,7 +37,7 @@ | |||
| "symfony/process": ">=3.4.47 <7.0", | |||
| "symfony/filesystem": ">=3.4.47 <7.0", | |||
| "vlucas/phpdotenv": "^4.3", | |||
| "ifsnop/mysqldump-php": "^2.12" | |||
| "druidfi/mysqldump-php": "^1.1" | |||
There was a problem hiding this comment.
this dependency is requiring PHP 7.4+
is it fine to raise the min php version?
There was a problem hiding this comment.
Version 3.5 must be compatible with PHP 7.1 to 7.4, for this reason, the dependency cannot be changed.
It's fine to update master with the new solution, but 3.5 will have to keep the existing one.
There was a problem hiding this comment.
thanks for pushing it over the finishing line
Version 3.5 must be compatible with PHP 7.1, up to 7.4. The `druidfi/mysqldump-php` dependency requires PHP 7.4.
| return parent::start($filename); | ||
| } | ||
| }; | ||
| $dumpSettings = ['add-drop-table'=> true, 'add-drop-database' => true]; |
There was a problem hiding this comment.
will the composer-35.json file use the same source code? if so, this line here might need a if-class-exist or similar construct so it works with both Mysqldump implementations?
There was a problem hiding this comment.
Yes, v3.5 is transpiled from v4 and will use the same code.
I've chased a missing db version update issue that was failing the tests, when that is solved, I will test v3.5 for issues, and will, likely put in place the conditional code.
|
Thank you @staabm again for your PR. |
|
thank you for the fast feedback :-). the contributions was a joy. |
the latest druidfi/mysqldump-php release - which is a PSR4 refactored, and regular maintained variant of https://github.com/ifsnop/mysqldump-php - is 8-10x faster then the origin upstream