-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: card atom #16
feat: card atom #16
Conversation
5f5eb72
to
7539f31
Compare
7539f31
to
1142ed7
Compare
In my mind I was picturing the Card component to be much simpler, something like:
, with frontFace and backFace being two svg urls. And that was it haha! I don't think having a Anyway, I think what you did is perfectly fine, just wanted to express my thoughts :) |
Well, what I was thinking for the PlayingCard is to be an extension of BaseCard. I called PlayingCard because I was referring to a "normal playing card". I would imagine a UnoCard or TarotCard if it's the thing. Specially because the type of entry would be different (I mean, you wouldn't instantiate the UnoCard with JokerBlack). Now about using the At server level, indeed, you could receive the data (like the SVG url). But then would that be a single SVG or an SVG sprite? Again, let's discuss during our call |
1142ed7
to
98cab20
Compare
98cab20
to
30f8d33
Compare
Closes #3 |
Objective
The idea here is to have a base card component and to extend it for the real cards.
This would enable for example to extend the card-ui to have:
This PR includes then:
Missing actions
Closes #16