Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScriptHandler.php is using deprecated CONFIG_SYNC_DIRECTORY #539

Closed
tormi opened this issue Dec 18, 2019 · 1 comment
Closed

ScriptHandler.php is using deprecated CONFIG_SYNC_DIRECTORY #539

tormi opened this issue Dec 18, 2019 · 1 comment

Comments

@tormi
Copy link

tormi commented Dec 18, 2019

CONFIG_SYNC_DIRECTORY is deprecated as per https://www.drupal.org/node/3018145. Affected rows: https://github.com/drupal-composer/drupal-project/blob/8.x/scripts/composer/ScriptHandler.php#L43-L47:

      $settings['config_directories'] = [
        CONFIG_SYNC_DIRECTORY => (object) [
          'value' => Path::makeRelative($drupalFinder->getComposerRoot() . '/config/sync', $drupalRoot),
          'required' => TRUE,
        ],
@tormi tormi mentioned this issue Dec 18, 2019
Closed
webflo added a commit that referenced this issue Dec 18, 2019
@webflo
Issue #539: Remove deprecated CONFIG_SYNC_DIRECTORY
04a3fe0
@webflo
Copy link
Member

webflo commented Dec 18, 2019

Thanks! Fixed in 04a3fe0

@webflo webflo closed this as completed Dec 18, 2019
@gagarine gagarine mentioned this issue Dec 28, 2019
Closed
lammensj pushed a commit to lammensj/drupal-project that referenced this issue Dec 30, 2019
@webflo @lammensj
Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY
02545d3
dannylamb pushed a commit to islandora-deprecated/drupal-project that referenced this issue Jan 2, 2020
@elizoller @weitzman
@zaporylie @morenstrat @webflo @rodrigoaguilera @milkovsky @mxr576 @grasmash @andypost @hansfn @MPParsley @petk @gagarine @foxtrotcharlie @greg-1-anderson @paulvandenburg @dannylamb
Update to Drupal 8.8.1 (#34)
b802bb3 
* Honor .env files and suggest usage (drupal-composer#351)

* Remove extra whitespace (drupal-composer#371)

* Updated argument name

* Bump minimal version

* Bump minimal version to 8.5.3

* Fix installer path for drush commandfiles.

* Update drupal-composer/drupal-scaffold

drupal-composer/drupal-scaffold is a full featured plugin and provides its own command.

* Fix tests on Travis CI (drupal-composer#405)

* Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404)

* Remove "drupal-scaffold" from scripts (drupal-composer#275)

* Fix typo in README.md

* Remove unused use statement. (drupal-composer#406)

* Adjust default core patch level to -p2. (drupal-composer#418)

* Bump minimum required composer-patches version to support default patch level (drupal-composer#410)

* Update composer.json to require latest stable version of Drupal (drupal-composer#424)

* Require zaporylie/composer-drupal-optimizations (drupal-composer#442)

* Issue drupal-composer#408: Bump minimum PHP version to 5.6

* Removing redundant "--stability dev" from installation command (drupal-composer#450)

Fixes drupal-composer#449.

* Added "composer-exit-on-patch-failure": true option to composer.json (drupal-composer#420)

* Sync new lines at the end of the files (drupal-composer#453)

* Quote wildcards to avoid issues in some shells (drupal-composer#456)

* Add PHP 7.3 to Travis CI (drupal-composer#476)

* Change createRequiredFiles messages to reflect what occured (drupal-composer#467)

* Drop PHP 5.6 testing (drupal-composer#489)

* Bump minimum version to 8.7.0 (drupal-composer#488)

* Update .travis.yml

* Deprecate PHP 7.0 and 7.1 (drupal-composer#518)

* Revert "Deprecate PHP 7.1" (drupal-composer#521)

This reverts commit 5085410.

* Issue drupal-composer#518: Bump minimum php version to 7.0.8

* Update CI to Ubuntu 18.04 (drupal-composer#520)

* Revert "Update CI to Ubuntu 18.04" (drupal-composer#526)

This reverts commit ee5bf36.

* Add 'contrib' to Drush commandfile installer path (drupal-composer#525)

* Prefer usage of && operator instead of "and" (drupal-composer#530)

* update to drupal 8.8.0

* replace webflo/drupal-core-require-dev with drupal/core-dev

* Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522)

* Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY

* update to 8.8.1

Co-authored-by: Moshe Weitzman <weitzman@tejasa.com>
Co-authored-by: Jakub Piasecki <jakub@piaseccy.pl>
Co-authored-by: Markus Orenstrat <markus.orenstrat@reinblau.de>
Co-authored-by: Florian Weber <florian@webflo.org>
Co-authored-by: Rodrigo <hi@rodrigoaguilera.net>
Co-authored-by: Norman Kämper-Leymann <leymannx@users.noreply.github.com>
Co-authored-by: Alex Milkovskyi <a.milkovsky@gmail.com>
Co-authored-by: Dezső BICZÓ <mxr576@users.noreply.github.com>
Co-authored-by: Matthew Grasmick <matthew.grasmick@acquia.com>
Co-authored-by: Andy Postnikov <apostnikov@gmail.com>
Co-authored-by: Hans Fredrik Nordhaug <hansfn@gmail.com>
Co-authored-by: Maarten Segers <MPParsley@users.noreply.github.com>
Co-authored-by: Peter Kokot <peterkokot@gmail.com>
Co-authored-by: Simon Perdrisat <perdrisat@gmail.com>
Co-authored-by: Charles Tanton <charlietnt@gmail.com>
Co-authored-by: Greg Anderson <greg.1.anderson@greenknowe.org>
Co-authored-by: Paul <1727604+paulvandenburg@users.noreply.github.com>
zanvidmar added a commit to oscarsergeant/drupal-project that referenced this issue Feb 12, 2020
@zanvidmar @MPParsley
@webflo @greg-1-anderson @paulvandenburg
update 8x branch (#4)
5c633a1 
* Deprecate PHP 7.0 and 7.1 (drupal-composer#518)

* Revert "Deprecate PHP 7.1" (drupal-composer#521)

This reverts commit 5085410.

* Issue drupal-composer#518: Bump minimum php version to 7.0.8

* Update CI to Ubuntu 18.04 (drupal-composer#520)

* Revert "Update CI to Ubuntu 18.04" (drupal-composer#526)

This reverts commit ee5bf36.

* Add 'contrib' to Drush commandfile installer path (drupal-composer#525)

* Prefer usage of && operator instead of "and" (drupal-composer#530)

* Use scaffold plugin and composer packages from Drupal core 8.8.0 (drupal-composer#522)

* Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY

Co-authored-by: Maarten Segers <MPParsley@users.noreply.github.com>
Co-authored-by: Florian Weber <florian@webflo.org>
Co-authored-by: Greg Anderson <greg.1.anderson@greenknowe.org>
Co-authored-by: Paul <1727604+paulvandenburg@users.noreply.github.com>
shrop pushed a commit to shrop/drupal-project that referenced this issue Apr 11, 2020
@webflo @shrop
Issue drupal-composer#539: Remove deprecated CONFIG_SYNC_DIRECTORY
40db001
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@webflo @tormi