-
Notifications
You must be signed in to change notification settings - Fork 942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.x] Better ScriptHandler.php, migrate from drustack/drustack-standard #167
Conversation
@hswong3i Wrong upstream repo? |
Sorry I remove the create web/modules web/themes and web/profiles code from script handler, so the test get failed (because I already remove that from my https://github.com/drustack/drustack-standard/blob/master/src/Composer/ScriptHandler.php) Latest commit try to create those folder manually ;-) |
Progress also backport and contribute to Drupal core, please kindly give a hand if possible: |
8de80df
to
ea284cb
Compare
ea284cb
to
2014560
Compare
2014560
to
f1e85c5
Compare
"authors": [ | ||
{ | ||
"name": "", | ||
"role": "" | ||
} | ||
], | ||
"autoload": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the original ordering better. This is just alphabetical but it is of little use. I think this better remain with contextual ordering.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reformat is mainly due to running :%!python -m json.tool
inside vim ;-)
f1e85c5
to
aa7722d
Compare
Some update due to https://www.drupal.org/node/2760467 changes. |
Closing this because its a huge change i won't copy the vendor cleanup script and info rewrite. We could create seperate plugins for it. |
Thanks for your work. Please review https://github.com/drupal-composer/info-rewrite or https://www.drupal.org/project/composer_deploy |
Migrate from https://github.com/drustack/drustack-standard/blob/master/src/Composer/ScriptHandler.php, include: