Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] Better ScriptHandler.php, migrate from drustack/drustack-standard #167

Closed

Conversation

hswong3i
Copy link

Migrate from https://github.com/drustack/drustack-standard/blob/master/src/Composer/ScriptHandler.php, include:

  • Original script handlers, clone from Drupal 8.x Drupal\Core\Composer\Composer
  • Generate info meta data into .info, logic clone from drush 8.x

@hswong3i hswong3i changed the title Better ScriptHandler.php, migrate from drustack/drustack-standard [8.x] Better ScriptHandler.php, migrate from drustack/drustack-standard Jun 21, 2016
@webflo
Copy link
Member

webflo commented Jun 21, 2016

@hswong3i Wrong upstream repo?

@hswong3i
Copy link
Author

hswong3i commented Jun 21, 2016

Sorry I remove the create web/modules web/themes and web/profiles code from script handler, so the test get failed (because I already remove that from my https://github.com/drustack/drustack-standard/blob/master/src/Composer/ScriptHandler.php)

Latest commit try to create those folder manually ;-)

@hswong3i
Copy link
Author

Progress also backport and contribute to Drupal core, please kindly give a hand if possible:

hswong3i added a commit to hswong3i/drupal-project that referenced this pull request Jul 6, 2016
hswong3i added a commit to hswong3i/drupal-project that referenced this pull request Jul 6, 2016
hswong3i added a commit to hswong3i/drupal-project that referenced this pull request Jul 6, 2016
"authors": [
{
"name": "",
"role": ""
}
],
"autoload": {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the original ordering better. This is just alphabetical but it is of little use. I think this better remain with contextual ordering.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reformat is mainly due to running :%!python -m json.tool inside vim ;-)

@hswong3i
Copy link
Author

Some update due to https://www.drupal.org/node/2760467 changes.

@webflo
Copy link
Member

webflo commented Mar 22, 2017

Closing this because its a huge change i won't copy the vendor cleanup script and info rewrite. We could create seperate plugins for it.

@webflo webflo closed this Mar 22, 2017
@webflo
Copy link
Member

webflo commented Mar 22, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants