Replace require-dev with webflo/drupal-core-require-dev #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@webflo why did you do that? I could not find the reasoning for this change. This change hides the require-dev dependencies inside an "empty" project, and makes it hard to override the dependencies on the fly. It broke mine (and probably others) continuous integration. |
|
@wundo I am sorry about that, but this project its a starterkit. I think you should not depend on it directly. Use it as a base, make it your own. Back to this specific change. The development dependencies got outdated over time. It was my goal to provide it as and standalone packages. I hope this makes it easier to update your project later on. |
hawkeyetwolf
pushed a commit
to kalamuna/drupal-project
that referenced
this pull request
Mar 9, 2018
…m-project * upstream/8.x: Improve update instructions (drupal-composer#366) Run tests with 8.6.x Update to Drupal 8.5 Add platform version to FAQ to help user specifying PHP version, fixes drupal-composer#359. (drupal-composer#360) Update /drush dir for Drush9 (drupal-composer#350) Revert "Update /drush dir for Drush9" Update /drush dir for Drush9 Replace require-dev with webflo/drupal-core-require-dev (drupal-composer#348) Bump drush version Replace GPL-2.0+ by GPL-2.0-or-later Run tests with 8.5.x (drupal-composer#329) Update README.md (drupal-composer#334) Update composer dependencies (drupal-composer#325) Declare compatibility with versions of Drush and CSS selector that are compatible with Drupal 8.4 and earlier. Added composer validate to CI. Update .travis.yml Update .travis.yml Add support for Drush 9 and Drupal 8.4
daften
pushed a commit
to district09/drupal8_project_template
that referenced
this pull request
Aug 9, 2018
* upstream/8.x: (22 commits) Remove unused use statement. (drupal-composer#406) Fix typo in README.md Remove "drupal-scaffold" from scripts (drupal-composer#275) Copy the editor config and gitattributes from drupal to the root. (drupal-composer#404) Fix tests on Travis CI (drupal-composer#405) Update drupal-composer/drupal-scaffold Fix installer path for drush commandfiles. Bump minimal version to 8.5.3 Bump minimal version Updated argument name Remove extra whitespace (drupal-composer#371) Honor .env files and suggest usage (drupal-composer#351) Improve update instructions (drupal-composer#366) Run tests with 8.6.x Update to Drupal 8.5 Add platform version to FAQ to help user specifying PHP version, fixes drupal-composer#359. (drupal-composer#360) Update /drush dir for Drush9 (drupal-composer#350) Revert "Update /drush dir for Drush9" Update /drush dir for Drush9 Replace require-dev with webflo/drupal-core-require-dev (drupal-composer#348) ... # Conflicts: # .gitignore # composer.json # drush/policy.drush.inc
shrop
pushed a commit
to shrop/drupal-project
that referenced
this pull request
Apr 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.