Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicate php requirement. #534

Closed
wants to merge 1 commit into from

Conversation

tormi
Copy link

@tormi tormi commented Dec 6, 2019

Remove duplicate php requirement already covered in vendor/drupal/core-composer-scaffold/composer.json.
re: d2e7410#commitcomment-36298565

@greg-1-anderson
Copy link
Collaborator

Generally speaking, I prefer for a project to declare its expected minimum PHP version in its top-level composer.json file. This is a form of documentation for folks looking at the project to evaluate its requirements e.g. by browsing source on GitHub.

On a technical level, though, you are correct that it is redundant to have this, and furthermore, as a project evolves, it is possible that the top-level PHP minimum version limit might become stale over time (e.g. after upgrading to Drupal 9), so you could also argue that it would be more DRY to take this out.

@petk
Copy link
Contributor

petk commented Jan 9, 2020

+1 for keeping the root composer.json php constraint as is. This is mostly also bumped many times to even more recent version based on the code in the project.

@tormi
Copy link
Author

tormi commented Jan 10, 2020

Fair enough.

@tormi tormi closed this Jan 10, 2020
@tormi tormi deleted the 8.x-remove-php-requirement branch January 10, 2020 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants