Skip to content

Issue #3190890 by cyb.tachyon: Patternkit allows empty categories but… #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: 9.1.x
Choose a base branch
from
Open

Issue #3190890 by cyb.tachyon: Patternkit allows empty categories but… #79

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Entity/Pattern.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,7 @@ public function getAssets() {
}

public function getCategory() {
return $this->getEntityKey('category');
return $this->getEntityKey('category') ?? t('default');
}

public function getDescription() {
Expand Down
4 changes: 2 additions & 2 deletions src/PatternLibraryPluginDefinition.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ public function setDescription($description) {
* The human-readable category of the definition.
*/
public function getCategory() {
return $this->category;
return $this->category ?? t('default');
}

/**
Expand All @@ -165,7 +165,7 @@ public function getCategory() {
* @return $this
*/
public function setCategory($category) {
$this->category = $category;
$this->category = $category ?? t('default');
return $this;
}

Expand Down
2 changes: 1 addition & 1 deletion src/Plugin/Derivative/PatternkitBlock.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ public function getDerivativeDefinitions($base_definition): array {
$this->derivatives[$pattern_id] = [
'category' => (string) t('Patternkit:@lib/@category', [
'@lib' => $lib ?? 'patternkit',
'@category' => $pattern->getCategory() ?? 'default',
'@category' => $pattern->getCategory() ?? t('default'),
]),
'admin_label' => t('[Patternkit] @pattern', ['@pattern' => $pattern->label()]),
'pattern' => $pattern,
Expand Down