Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewport issues with Radix panels layouts #155

Open
katypool-zz opened this issue Nov 21, 2014 · 13 comments
Open

Viewport issues with Radix panels layouts #155

katypool-zz opened this issue Nov 21, 2014 · 13 comments

Comments

@katypool-zz
Copy link

So the update to Panopoly 1.14 switched panels layouts from the old Panopoly theme to Radix. But the Radix css isn't playing nice with Kalatheme and messes with fixed width. Read all about it here: https://www.drupal.org/node/2379315

Very easily fixable. There needs to be another container div in kalatheme's page.tpl.php in order for it to integrate seamlessly with the Radix layouts.
Now you know!

@shadcn
Copy link

shadcn commented Nov 21, 2014

We had to add the .container wrapper to Radix as well.

See the related issue here: https://www.drupal.org/node/2334871

@pirog
Copy link
Contributor

pirog commented Nov 21, 2014

thanks @arshad!

@katypool any chance we can coax a pull request from you with the container class added as per https://www.drupal.org/node/2334871?

@katypool-zz
Copy link
Author

will do

@pirog
Copy link
Contributor

pirog commented Nov 21, 2014

THX

On Fri, Nov 21, 2014 at 11:49 AM, katypool notifications@github.com wrote:

will do


Reply to this email directly or view it on GitHub
#155 (comment)
.

Cheers,

Mike Pirog
Kalamuna
www.kalamuna.com

labboy0276 pushed a commit to labboy0276/kalatheme that referenced this issue Jan 14, 2015
@labboy0276
Copy link

@pirog @reynoldsalec PR put in

@pirog
Copy link
Contributor

pirog commented Jan 14, 2015

not super familiar with the implications here so i defer to others.

if this is relevant lets make sure it gets into the 4x branch (ie kalatheme-source) as well.

@labboy0276
Copy link

fixes all things

@dariogcode
Copy link

I think this change is valid if we use the Radix layout direcly, without trying to override in the Kalatheme tpls.

From the last Panopoly update I noticed the Kalatheme tpl files for layouts (kalatheme\templates\panopoly) aren't overriding the Panopoly theme layouts (radix layouts)

Previous
In the kalatheme tpl files for layouts you will notice all use the ".container" class. which make unnecesary to add an additional container in page.tpl. This approach also let you to create a fuild container if you need it, in the panel layout. But as mentioned, this isn't working now.

Actual
With the latest Panopoly changes, Radix layout have the ".container-fluid" class which make everything fuild bcause our page.tpl don't have a container class. Adding a container in tpl will increase padding because we will have 2 container in the tree.

Hope this is clear, my apologize for my english.

Thanks!

@dariogcode
Copy link

Which works pretty good for me is change the name of the tpl in templates/panopoly adding "radix-" as prefix, for example bryant.tpl.php change to radix-bryant.tpl.php

@maxplus
Copy link

maxplus commented Apr 7, 2015

Hi tilon,

The old Panopoly 1.13 layouts worked perfect together with Kalatheme and so I was a little bit lost with the new Radix layouts because they have built in the default 12 columns grid and do not support to use a (for example) 24 columns grid.

=> now by changing the tpl name of the layout files (included in the templates folder of my custom theme, copied from the Kalatheme base folder) by adding "radix-", I can still keep using the current radix-layouts.

Thanks!

soniktrooth added a commit that referenced this issue Apr 23, 2015
#155 fix page.tpl for new radix layout based panopoly
gboudrias pushed a commit to PraxisLabs/kalatheme that referenced this issue Apr 23, 2015
@gboudrias
Copy link

This is also occurring in v4. See PR 174.

soniktrooth added a commit that referenced this issue Jun 6, 2015
#155 fix page.tpl for new radix layout based panopoly (v4 branch)
@andrewmallis
Copy link
Member

@madeofpeople – take a look svp?

@thiagodemellobueno
Copy link
Contributor

Seems like using the radix layouts in panopoly is the way to go.
So @tilon 's suggestion is valid, but we shouldnt really duplicate those files so much as make the templates available to kalatheme?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

10 participants