Missing comma breaks menu_local_task markup #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
im a little out of the loop on this so it would be great to get the thumbs up from either @madeofpeople @RobLoach or @andrewmallis |
|
inspecting the code, it does look like this is a legit typo. |
|
If I do one too then it can be a high five and that's better than thumbs up ✋ |
|
::hand:: ::hand:: |
|
This is tested and working over on CITC—can someone merge it? I don't have write access yet. |
soniktrooth
force-pushed
the
7.x-3.x-missing-comma-local-task
branch
from
19c1a0a
to
d2851c9
Compare
pirog
added a commit
that referenced
this pull request
Apr 22, 2015
…task Missing comma breaks menu_local_task markup
|
done also @soniktrooth i gave you write acess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This didn't seem to be disastrous when I was looking at it in Chrome but I imagine it could kill and older browser.