Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #46: Update Composer requirements. #47

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

FlorentTorregrosa
Copy link
Collaborator

This PR update friendsofphp/php-cs-fixer version constraint.

Fixes #46 .

@FlorentTorregrosa
Copy link
Collaborator Author

Getting the same pipeline error as for the main branch.

@drupol
Copy link
Owner

drupol commented Jun 27, 2023

Could you please justify this change and why 3.18 instead of another like 3.19.2 ?

@FlorentTorregrosa
Copy link
Collaborator Author

Hi,

As explained in the related issue #46, blank_lines_before_namespace rule had been introduced into 3.18.0. So updating to the version allowing the maximum compatibility.

If you prefer I can put 3.19.

I think fixing the bugfix version part is not a good idea as it prevents minor updates.

@drupol drupol merged commit 4abfb0b into drupol:master Jun 27, 2023
@drupol
Copy link
Owner

drupol commented Jun 27, 2023

Hi,

As explained in the related issue #46, blank_lines_before_namespace rule had been introduced into 3.18.0. So updating to the version allowing the maximum compatibility.

If you prefer I can put 3.19.

I think fixing the bugfix version part is not a good idea as it prevents minor updates.

Fair enough, thanks!

@FlorentTorregrosa FlorentTorregrosa deleted the 46 branch June 27, 2023 20:16
@FlorentTorregrosa
Copy link
Collaborator Author

Thanks for the quick reply and merge :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Composer requirements
2 participants