Fix reestablish wrong deleted line. Raise minimum requirements. #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why not using the latest version directly ? |
FlorentTorregrosa
force-pushed
the
deprecations
branch
from
e7f971e to
84288c4
Compare
FlorentTorregrosa
changed the title
|
If you want I can, in fact I hesitated to do that. It was to keep maximum compatibility. But ok to go to Edit: So should I force 3.35? |
|
I think we should indeed use the latest version all the time, for such a tool there should not be any compromise. I also fixed the coding style on master branch, tests should be passing. |
FlorentTorregrosa
force-pushed
the
deprecations
branch
from
84288c4 to
2f26929
Compare
100% Agreed. PR rebased and requirement increased. |
drupol
reviewed
Oct 18, 2023
|
Merci ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Follows #52 .
Fixes #52.