Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

drush core-requirements does not output descriptions in render arrays #1314

Closed
pfrenssen opened this issue Apr 2, 2015 · 1 comment
Closed
Assignees

Comments

@pfrenssen
Copy link
Member

In issue #2296929: Clean up system_install() SafeMarkup::set() use it was discovered by herved that drush rq does not output descriptions that are rendered with render arrays correctly. Instead it shows Array.

This is because the concatenate-columns option is used to format the table. This treats the input data as strings and simply concatenates them.

The table formatter actually expects all input data to be raw strings. To make it possible to use arrays and objects in the input data we could provide a callback function that preprocesses the data of particular columns before trying to format it. This would solve it in a generic way.

pfrenssen added a commit to pfrenssen/drush that referenced this issue Apr 2, 2015
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 1, 2017
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 1, 2017
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 4, 2017
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 10, 2017
…quirements does not output descriptions in render arrays
weitzman pushed a commit that referenced this issue Feb 10, 2017
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 10, 2017
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 10, 2017
…quirements does not output descriptions in render arrays
AdamPS added a commit to AdamPS/drush that referenced this issue Feb 11, 2017
weitzman pushed a commit that referenced this issue Feb 14, 2017
* Fix issue #1314: drush core-requirements does not output descriptions in render arrays

* Correction to previous commit for issue #1314: drush core-requirements does not output descriptions in render arrays

* Issue #1314: add D6 version
@AdamPS
Copy link
Contributor

AdamPS commented Feb 14, 2017

Thanks @weitzman I think this is now fixed and ready to close.

mikeker pushed a commit to mikeker/drush that referenced this issue Aug 10, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants